MV - Dual Wield

Hey there.

The only plugin from that system that I know it works with is the weapon swap plugin, and only if you download the included patch. Even then, it doesn't work very well at all, especially in the menus.

Olivia disabled dual wielding in that plugin (probably in the other octopack plugins as well), either because in a true octopath-based battle system, there would be no dual wielding, or because there was some kind of issue with dual wielding she couldn't fix.

In either case, as I only own a copy of the weapon swapping plugin, it is the only one I have made a patch for. Since it appears from that plugin alone that Olivia didn't want dual wielding in the octopack, it's likely it's been disabled in one or all of the other plugins as well, and probably causes even more issues with them if you were to use my patch.

I toyed with this earlier, and it's possible via a conditional branch in your action sequence for the attack skill.

Because the target action part of the sequence is repeated for each attack, if you wrap the whole thing in an if check that checks the targets HP, you can effectively not do the second (or any subsequent) swings if the target has 0 HP.

When I was investigating a bug report a few weeks ago, I'd forgotten I'd set this up on my action sequence in my test project, and thought my update had broken the offhand attack, but it turned out my first hit was strong enough to kill the target.

if (target.hp > 0)
motion attack: user
wait: 12
action animation: target
action effect: target
wait for animation
else
death break
end

Hello there.

I can see that the plugin you linked is supposed to be compatible with Yanfly's Battle Engine plugin, but I am unsure just how far that compatibility goes. I don't have a leTBS project set up to test from at the present, and it will not be a quick task for me to do so, as I don't personally use that plugin myself.

Since I'm not sure how much of BattleEngineCore actually makes it into use in leTBS, I'm not real sure where the incompatibility actually is. It could be as simple as the Attack Times+ trait not functioning in leTBS, or it could be as complex as action sequences not being implemented at all. Or both. 

To start, could you describe what does or doesn't happen when testing in your own project? Does a second attack occur for dual wielding actors at all, just with the wrong damage/animation/weapon, or does only one attack happen? If only one attack happens, does it show both the battle animations for each weapon on top of each other, or just one animation? Does it simply crash and not work at all?

I expect the menu stuff should probably still be working fine, except unless leTBS has some sort of in battle status menu, in which case it would need to be patched to work with the offhand weapon slot properly.

I can't guarantee I'll be able to patch it to make it compatible, but I can give it a shot.

-Ramza

Hello again.

I apologize for how long it took me to get back to you on this one. Unfortunately, after digging into the LeTBS plugin a bit, I can only conclude that I don't know enough about how this plugin works to get it working together with dual wield. 

I tried to find the part of the plugin where it processes the attack action specifically, as a starting point for how to make this compatible, but the plugin is massive, and has little documentation. Blindly poking around inside did not prove to be very effective. If support for Attack Times + as a trait were to be built into leTBS, I feel like dual wield would probably work almost 100% with just that change, but since I can't personally figure out where the attack sequence is even processed, let alone what to change to make it duplicate certain parts of it, I will be unable to do this myself.

There are also some unforeseen compatibility issues to do with the lack of working action sequences in leTBS. My plugin relies on secretly adding commands to the action sequences to reset some attack data between skill uses, which is why YEP_BattleEngineCore is a hard requirement. While leTBS supports BattleEngineCore, it does not seem to make use of action sequences at all, which means any compatibility patch between my plugin and leTBS will need to find a new way to reset this attack data.

As it is right now, you can use dual wield and the extensions with this plugin, but they do not split damage, or effects, or hit multiple times. You can still use this to make dual wield actors capable of wielding shields in their offhands, make weapons that can only be wielded in the main or off hands, or two-handed, and make shields that can be wielded with two-handed weapons. As is, the only thing I could suggest to try to get the core features of this plugin to work are to contact someone who has a lot more experience working on the leTBS plugin.

Sorry.

That's a decent suggestion, but it doesn't account for shields tagged <Offhand>. These shields can be equipped even when an actor has a two-handed weapon equipped, so there is always the possibility of equipping something in that slot, even when a two-handed weapon is being used.

Of course, one could say that for a project where shields aren't a thing, or where light shields don't exist this is a good suggestion. I'd like to keep this plugin as cookie-cutter as possible, though, so I don't think I can roll this into the main plugin.

However, for your own personal use, I'd look into the below function from YEP_EquipCore. The function is used to draw the 'empty' slots on the equip scene, and you can add in whatever functionality you need from here.

Window_EquipSlot.prototype.drawEmptySlot = function(wx, wy, ww) {
    this.changePaintOpacity(false);
    var ibw = Window_Base._iconWidth + 4;
    this.resetTextColor();
    this.drawIcon(Yanfly.Icon.EmptyEquip, wx + 2, wy + 2);
    var text = Yanfly.Param.EquipEmptyText;
    this.drawText(text, wx + ibw, wy, ww - ibw);
};

Add in an if condition, and check this._actor.icanMonkeyGrip() or alternatively a (this._actor.equips()[0] && !this._actor.equips()[0]._isTwoHanded) and that should handle what you're looking for.

Might come out a little something like this:

Window_EquipSlot.prototype.drawEmptySlot = function(wx, wy, ww) {
    this.changePaintOpacity(false);
    var ibw = Window_Base._iconWidth + 4;
    this.resetTextColor();
    if (!this._actor.canMonkeyGrip()){
        this.drawIcon(Yanfly.Icon.EmptyEquip, wx + 2, wy + 2);
        var text = "Locked";
        this.drawText(text, wx + ibw, wy, ww - ibw);
    } else {
        this.drawIcon(Yanfly.Icon.EmptyEquip, wx + 2, wy + 2);
        var text = Yanfly.Param.EquipEmptyText;
        this.drawText(text, wx + ibw, wy, ww - ibw);
    }
};

Just paste that code into a blank js file and import it into your plugin manager anywhere below YEP_EquipCore and that should do it.

-Ramza

Greetings.

Thanks for the report. This issue is caused because I had hardcoded the value to draw the offhand attack text/dark rectangle to offset from the first one by 30 pixels. The standard padding is 32, if I'm not mistaken, and to make room on the default resolution screen, I shrunk it by 2 pixels, and injected the offhand line using the extra space that afforded.

I can push an update that un-hardcodes this value, allowing you to specify it in cases like yours, where you've changed the default line spacing to make up for a resolution change and/or larger font choice.

Alternatively, you can manually make this change. Between lines 1205-1257 there are several calls which reference a 'y+30'. If you change that 30 to something slightly larger, it will shift the line down a bit. Fiddle with that number until you get equal spacing between the Off Strength line and the Toughness line below it and you should be good to go.

Edit:

Turns out, I had a few minutes, and since I'd already went to the trouble of finding out which lines to change, I went ahead and fixed it in v1.34. I have just uploaded the updated menu extension plugin, you can download it here.

The boxes for the dual wield modifiers (two-hand, offhand, dual wield damage %) are javascript evals.

This means you can use a ternary operator to make the value one of two values depending on a conditions.

if you put the following in your offhand modifier parameter box, it will increase the offhand damage to 90% if the actor has a state, or if the actor doesn't have the state, 75%.

(this.isStateAffected(X)) ? 0.9 : 0.75

because of the way the plugin uses this formula (this) is the actor. In the above statement, if the actor is affected by state X, his offhand modifier is 90%, but if he isn't, it's the base 75%.

You can also nest these, if you have multiple states that change the penalty (or grant bonuses)

(this.isStateAffected(X)) ? 0.9 : (this.isStateEffected(Y)) ? 0.99 : 0.75

It doesn't have to be a state either, anything on the actor object can be used, such as his name:

(this.actor().name == 'Harold') ? 1.12 : 0.75

Hope this helps.

I have corrected this in the latest revision B. It is available at the same download location.

Apologies for all the problems with this, like I said, I didn't get much of a chance to actually QA test it before I put it up.

Greetings.

I didn't previously have a way to do this, but I just rolled it into the menu extension addon. Someone had asked a question earlier about the names of the slots, and it made me think that he was asking for this feature, so I'd started looking into ways to do it. But then it turned out I misunderstood what he was asking for, so it wasn't needed anymore.

If you also have the monkey grip plugin, you'll need to update it to the newly released version 1.01 to support the slot name changes I made in v1.33 just now. Let me know if there are any issues with it, I didn't get much of a chance to thoroughly QA test it myself, beyond making sure it displays correctly, and doesn't cause a crash (of which, there were several).

-Ramza

The menu extension plugin contains parameters for you to set what the main and offhand slots are called. The default is just 'Main' and 'Off'. Using longer names like 'Right-hand' make the status scene look a bit squished, but on wider resolutions that would look fine too.

Unless I'm misunderstanding you, and you're actually looking for a way to dynamically name that slot... Like some actors it says 'right' and others it says 'primary'. That's something I can definitely do if you're looking for it.

This is the first I've heard of that problem, but given how much of a pain it was to implement that feature, it wouldn't surprise me at all to learn there's still a bug or two with it.

I'm at work for the next several hours, but when I get home I'll be able to take a closer look. If you could verify if the normal attacks are actually using the stats of the locked weapon, by slapping wildly unrealistic ATK values on them, that'll save me a few minutes in tracking down the issue though. If not, no big deal, I'll have a look when I can.

This looks like the same issue Miah1377 reported after updating from an older version.

That function being referenced as the cause of the crash is trying to read a property that is assumed to be present on all weapons as of v2.62. I just released a sort of patch that stops it from causing the crash error, but the cause of the problem is that it appears that you are testing using a save file that was made prior to upgrading the plugin to version 2.62. The way the database for items is loaded is weird, and because this plugin wasn't reading notetags for locked wtypes prior to v2.62, the property that it saves onto weapons isn't present on your items database for the save file. The plugin (prior to 2.65) assumed that the property is always present, so it goes right to reading from it, which causes the crash error you posted when it finds the property as undefined.

As I said, v2.65, which was just uploaded a few hours ago will stop the crash (or it should anyway), but the actual fix is to start a new save-game file from which to test further.

Greetings.

Sorry for the problem here, but the error code you posted is just what I needed to track this down. The problem here is that I believe you are using an old save to test your project, before you installed the new version of this plugin. That function causing the error is checking an array that should be present on all weapons as of the 2.62 update - specifically, even weapons that do not prevent the use of other wtypes will still have this value, it's simply blank, so it doesn't cause this error.

The simplest way to prevent this error is to start a new save-game in your project to test. I have just uploaded version 2.65, which will also correct this issue (causing crashes isn't good, even if the reason isn't exactly the plugin's fault).

I'm not 100% sure, as I don't use that plugin myself, but I believe Weapon Unleash is coded in such a way as that all other plugins think the new skill is the attack skill, so it should properly do atk calculation. 

Keep in mind, though, that dual wielding unleashed weapons does not work correctly. The offhand weapon's unleash skill is ignored, so the mainhand skill is used twice. This is because the Weapon Unleash plugin doesn't include dual wielding support at all.

At which point are you noticing delay? For dual wield actors, and only when using a dual wield skill (one tagged as dual wield) this plugin does copy sections of the target action and replays them, but only if you've got it set up to do that. If you're not using it in that way, it shouldn't cause any delay to the actual action sequence, and even in the above example, it shouldn't cause any noticeable effect.

Hello there.

It would appear that this is an uncaught bug caused in v2.55, when I added some checks to lock main or offhand weapons on actors who were using skills that required a specific weapon type. It looks like after this update I was also checking for locked weapon types on enemies, who don't use weapons, and therefore throw this error.

I have uploaded a fix, and apologize for the inconvenience. The reason why it worked in my demo project was because the uploaded demo project is using an older version of the plugin. Redownloading the plugin file from the download page will show it updated to v2.58 with this fix included.

Thanks for reporting this issue.

I'm not familiar with that plugin. However, the 'disable state' option in my plugin 's parameters can be used for exactly the scenario you describe. Try putting it as a passive on the arrow weapons and see how it works out.

I'm honestly not sure how it will work out with the arrows being weapons, though, so you might need a more creative workaround. Technically, you could make them shields and they'd still fit in the offhand, and their base parameters would be added to the single attack of the main hand weapon in that case. They'd need to be etypeId 2 specifically for that to work without modifying my plugin, though. You'd probably need some special equipment requirements to prevent a player from equipping arrows as a shield without a bow, or something as well.

Greetings again. I have corrected the problem.

I had thought that I had tested the logic quite thoroughly on my own, but it turns out I must've skipped the checks to see if having no weapons in either hand would cause a problem. I have added the required checks, and the project should no longer crash when either of the actor's hands are empty, when using a skill that requires a specific weapon type. Please download the updated plugin file at your earliest convenience.

Good day Gregaur-X.
If you are actually using version 1.05 I have to commend you on actually even getting it to work at all! Way back in June 2017 I scrapped the old version of this plugin and rewrote it as version 2.0 and it has had numerous updates and fixes since then. I was having problems similar to the ones you mentioned, as well as issues where weapons would lose their stats entirely. The way I had written it was too obtuse for the average person to even figure out how to use it (myself included), so I rewrote it to be a lot more user friendly. 

Version 2 was almost exactly the same as version 1.05, except it was plug and play. You didn't need to call any functions during your action sequences, or set up anything before the swing, when you attacked it hit twice, and looked different if you had two different weapons, and that was all it needed to do.

I can tell you for sure and without a single doubt that if you purchase the new version of the plugin you will not run into this problem any more, although you might have to change some stuff on your action sequences around to make them work again.

-Ramza

I have seen this issue before in the past, so I suspect the cause is the same.

You are using a weapon to enable dual wielding on the actor. Likely the mainhand weapon, based on what you've said so far. 

During the attacks, each weapon is temporarily unequipped to remove all of the traits from it when it isn't being used. The offhand weapon is removed first, so the main hand swing will only use traits from the first weapon. Afterward, the offhand weapon is re-equipped, and the main hand weapon is removed so the same can happen with the offhand swing. When the main hand weapon is removed, your actor is updated to not be capable of dual wielding anymore, because the dual wield type trait is on that weapon. This removes his offhand weapon as well, causing him to continue the second strike, but with his main (bare) hand instead. 

After this happens, checking in the menu will show the offhand weapon as unequipped, and likely gone from the inventory as well.

To fix this, add the dual wield type to the actor, or class directly, instead of to the equipment he/she is wearing.