Version 1.24 Bugfix

Greetings all.

I have uploaded version 1.24 which corrects a couple of longstanding, but generally hard to find bugs with additive ingredient traits.

• Corrected an issue where hp and mp recovery traits were not being added together correctly when multiple ingredients in a recipe had them.
• Corrected an issue with skyrim-like traits mode, where all traits that were passed to a result item were also being passed to the last ingredient in the recipe.
  • Ordinarily this wouldn't cause any noticeable effect, as that ingredient is taken from the inventory when the item is crafted.
  • If the item was not consumable on success, or if the ingredient was not an independent item, though, the player could reuse the ingredient and it would pass all of the traits of all of the previous ingredients onto the next result item, effectively doubling the traits added to the result item.
  • This effect stacked as well, so the unexpectedly high stats of the second item would pass to the third, and so on.

The skyrim-like traits bug was reported by Vis_Mage, and I'd thought I'd corrected it before, but I couldn't actually reproduce what he was describing exactly. He was able to provide me with a small sample project where the issue could be easily observed, so I was able to quickly find and correct the problem.

This is a good example of a bug that is very hard to test for. With the number of different plugin parameters that everyone could be using, sometimes it's very hard to pin down what the actual problem is. In this case, the only way to see the problem was specifically to have ingredient items tagged as not being independent items, which I had not been testing for. In retrospect, in an actual commercial game, this is probably how you'd want them to be in the first place, since buying ingredients one at a time is a real drag. I wouldn't have ever considered that setting to be something to try, let alone test, and if I hadn't been provided with a test project where the issue was happening, I probably would've never found the bug on my own.

So once again, thanks to Vis_Mage for finding that one.

~Ramza